Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: field components #997

Merged
merged 4 commits into from
Apr 11, 2024
Merged

refactor: field components #997

merged 4 commits into from
Apr 11, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 11, 2024

This PR includes a number of cleanup and consistency items, including

  • consistent naming of components and prop interfaces
  • rename optional placeholder -> helpText for checkbox and radio groups
  • fix formatting of helpText for checkbox and radio groups
  • add optional disabled prop to radio groups
  • 100% test coverage (statements, branches, functions, lines, oh my!)

@setchy setchy added this to the Release 5.3.0 milestone Apr 11, 2024
@setchy setchy added the refactor Refactoring of existing feature label Apr 11, 2024
@setchy setchy merged commit fc8adcb into main Apr 11, 2024
7 checks passed
@setchy setchy deleted the refactor/field-components branch April 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos afonsojramos approved these changes

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@setchy @bmulholland @afonsojramos