Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Running the contributed command:'gitlens.diffWithPrevious' failed." with keybinding not working #366

Closed
etiennejcharles opened this issue May 4, 2018 · 3 comments
Closed

"Running the contributed command:'gitlens.diffWithPrevious' failed." with keybinding not working #366

etiennejcharles opened this issue May 4, 2018 · 3 comments
Assignees
@eamodio
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature bug Something isn't working

Comments

@etiennejcharles
Copy link

  • GitLens Version: 8.2.4
  • VSCode Version: Version 1.24.0-insider (1.24.0-insider)
  • OS Version: 10.13.4

Steps to Reproduce:

  1. Disable all extensions, run it with the insiders build with only Gitlens enabled.
  2. In your settings.json only keep the "gitlens.keymap": "alternate", setting.
  3. Try to run the keyboard shortcut alt+,
  4. See the bug
@eamodio
Copy link
Member

eamodio commented May 5, 2018

Thanks for the report, it looks like a recent change to the insiders build broke me: microsoft/vscode#42851

@eamodio eamodio self-assigned this May 5, 2018
@eamodio eamodio added bug Something isn't working blocked: vscode Caused by or dependent on a VS Code issue or feature labels May 5, 2018
@eamodio eamodio added this to the Soon™ milestone May 5, 2018
@eamodio
Copy link
Member

eamodio commented May 5, 2018

FYI, I've released a beta version of the upcoming 8.3 release here with this fixed: https://github.com/eamodio/vscode-gitlens/releases/tag/v8.3.0-beta

eamodio added a commit that referenced this issue May 21, 2018
@eamodio
Fixes repo fallback on many commandsFixes #366 - deals null parameter…
6d15b90 
…s from command callbacks
@eamodio eamodio removed this from the Soon™ milestone Jul 19, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eamodio @etiennejcharles