Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor #546

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Remove vendor #546

merged 2 commits into from
Feb 10, 2021

Conversation

armsnyder
Copy link
Collaborator

Option, if we aren't vendoring anymore

Closes #544
Closes #545

@roidelapluie
Copy link
Collaborator

Can you resolve the conflicts?

@armsnyder
Copy link
Collaborator Author

armsnyder commented Feb 3, 2021

@roidelapluie I resolved the conflict by removing the "set build variables" stage entirely, since the only remaining build variable was GO111MODULE=on, which shouldn't be required anymore since Go 1.13, as it will detect the go.mod in Go 1.13+.

@armsnyder
Copy link
Collaborator Author

@roidelapluie Can you take a look here? We have another go-gitlab dependency update incoming (#444), so it would good to merge this now if it's ready.

@roidelapluie roidelapluie merged commit c7f0604 into gitlabhq:master Feb 10, 2021
@roidelapluie
Copy link
Collaborator

Thanks!!

@armsnyder armsnyder deleted the 544-rm-vendor branch February 10, 2021 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Check /vendor in CI
2 participants