Fix group_share_group nil pointer reference #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only set expires_at field when time is not nil. Update associated tests.
|
Could you review this PR? Thanks! |
mattkasa
approved these changes
Feb 9, 2021
mattkasa
reviewed
Feb 9, 2021
mattkasa
requested changes
Feb 9, 2021
Add empty string when gitlab_group_share_group expires_at time is null
|
lgtm after the last couple commits 👍 |
mattkasa
approved these changes
Feb 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://github.com/gitlabhq/terraform-provider-gitlab/issues/524
Updates resource
gitlab_group_share_group. It only sets expires_at field when time is not nil.