Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Fix to handle the error that the webhook is not found when an user deactivates #254

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

noahingh
Copy link
Member

@noahingh noahingh commented Dec 6, 2021

Sometimes, the webhook is not found for some reason. For example, a user deletes the webhook in GitHub. For seamless user experience, the server handles the error that the webhook is not found.

@noahingh noahingh added the component: server This issue or pull request is related to the feature of the server-side label Dec 6, 2021
@noahingh noahingh added this to the v0.4 milestone Dec 6, 2021
@noahingh noahingh linked an issue Dec 6, 2021 that may be closed by this pull request
Comment on lines +27 to +35
// ErrorCodeEntityNotFound is the entity is not found.
// Entity is a resource of store or scm.
ErrorCodeEntityNotFound ErrorCode = "entity_not_found"
// ErrorCodeEntityUnprocessable is the entity is unprocessable.
ErrorCodeEntityUnprocessable ErrorCode = "entity_unprocessable"

// ErrorCodeInternalError is the internal error couldn't be handled.
ErrorCodeInternalError ErrorCode = "internal_error"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort alphabetically

@noahingh noahingh merged commit bb22d1a into main Dec 8, 2021
@noahingh noahingh deleted the fix-webhook-handler branch December 8, 2021 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: server This issue or pull request is related to the feature of the server-side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix to handle the exception from deleting the empty webhook
1 participant