Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Remove the Slack interaction #275

Merged
merged 4 commits into from
Dec 18, 2021
Merged

Remove the Slack interaction #275

merged 4 commits into from
Dec 18, 2021

Conversation

noahingh
Copy link
Member

@noahingh noahingh commented Dec 18, 2021

Tests

  • Connect / Disconnect Slack
  • Slack Notification

Check List

  • Update the documentation

@noahingh noahingh added the bug Something isn't working label Dec 18, 2021
@noahingh noahingh added this to the v0.5 milestone Dec 18, 2021
@noahingh noahingh linked an issue Dec 18, 2021 that may be closed by this pull request
Comment on lines -235 to -236
slackapi.POST("/interact", m.Verify(), m.ParseIntr(), m.SetChatUser(), slack.Interact)
slackapi.POST("/command", m.Verify(), m.ParseCmd(), m.SetChatUser(), slack.Cmd)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove /interact, /command API to delete Chatops

@@ -2,33 +2,17 @@
// Use of this source code is governed by the Gitploy Non-Commercial License
// that can be found in the LICENSE file.

// +build !oss
//go:build !oss
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After version 1.17, GO provides a build constraint called build tag like below:

//go:build !oss

@noahingh noahingh marked this pull request as ready for review December 18, 2021 10:21
@noahingh noahingh merged commit df878a7 into main Dec 18, 2021
@noahingh noahingh deleted the rm-chatops branch December 18, 2021 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Chatops (deploy, lock) except for the notifcaiton.
1 participant