Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow const as argdep #164

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Allow const as argdep #164

merged 1 commit into from
Sep 20, 2023

Conversation

csweichel
Copy link
Collaborator

Description

Prior to this change the following component would not build without passing foobar as build arg:

const:
  - foobar=baz
packages:
  - name: demo
    type: generic
    argdeps:
      - foobar

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #164 (874802a) into main (e591a13) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #164      +/-   ##
========================================
- Coverage   8.36%   8.36%   -0.01%     
========================================
  Files         20      20              
  Lines       3406    3409       +3     
========================================
  Hits         285     285              
- Misses      3069    3072       +3     
  Partials      52      52              

@csweichel csweichel merged commit b18619b into main Sep 20, 2023
8 checks passed
@csweichel csweichel deleted the cw/allow-const-as-argdep branch September 20, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants