-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full] add bash auto-complete for cargo #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, and agreed! 👍 Thanks a lot @JesterOrNot.
However, if you look just 5 lines below, you'll see this line:
workspace-images/full/Dockerfile
Line 266 in 85da372
&& .cargo/bin/rustup completions bash | sudo tee /etc/bash_completion.d/rustup.bash-completion > /dev/null \ |
I think it would be better to just add "cargo" to that line. 😇
89d8b3a
to
4281ac7
Compare
full/Dockerfile
Outdated
@@ -263,7 +263,7 @@ RUN cp /home/gitpod/.profile /home/gitpod/.profile_orig && \ | |||
rls \ | |||
rust-analysis \ | |||
rust-src \ | |||
&& .cargo/bin/rustup completions bash | sudo tee /etc/bash_completion.d/rustup.bash-completion > /dev/null \ | |||
&& .cargo/bin/rustup completions bash cargo | sudo tee /etc/bash_completion.d/rustup.bash-completion > /dev/null \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my bad, it seems that rustup completions bash cargo
actually only outputs completions for cargo
, and that you still need to use rustup completions bash
separately.
@JesterOrNot Could you please double-check?
In case both are needed, we could do it like this:
&& .cargo/bin/rustup completions bash cargo | sudo tee /etc/bash_completion.d/rustup.bash-completion > /dev/null \ | |
&& .cargo/bin/rustup completions bash | sudo tee /etc/bash_completion.d/rustup.bash-completion > /dev/null \ | |
&& .cargo/bin/rustup completions bash cargo | sudo tee /etc/bash_completion.d/rustup.cargo-bash-completion > /dev/null \ |
4281ac7
to
368cb2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks good to me! 👍
Thanks @JesterOrNot
Thanks, merging! 🚀 |
This adds badly needed autocompletion for the cargo command