Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades #32

Closed
wants to merge 2 commits into from
Closed

Upgrades #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e54b1f9
Bump Ruby to 2.5.3
jankeromnes Dec 4, 2018
2613b1d
Bump Node.js to 10 LTS
jankeromnes Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions full/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ RUN pip install virtualenv 'python-language-server[all]'==0.19.0
RUN gpg --verbose --keyserver hkp://pgp.mit.edu --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3
RUN curl -sSL https://get.rvm.io | bash -s stable

ENV RUBY_VERSION=2.5.1
ENV RUBY_VERSION=2.5.3
RUN /bin/bash -l -c "rvm requirements && rvm install $RUBY_VERSION && rvm use $RUBY_VERSION --default && rvm rubygems current && gem install bundler --no-doc --no-ri"

# Rust
Expand All @@ -70,7 +70,7 @@ RUN $HOME/.cargo/bin/rustup update \
&& $HOME/.cargo/bin/rustup component add rls-preview rust-analysis rust-src

# Install nvm with node and npm
ENV NODE_VERSION 8
ENV NODE_VERSION 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on Theia requires node version 8. We'd need to create a custom image for Theia then, right?

Copy link
Contributor Author

@jankeromnes jankeromnes Dec 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that upgrading to node 10 used to break Theia's install, but this has now been fixed. Are there any other Theia / node 10 blockers that I'm not aware of? We should probably test this, and maybe take it upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. I've seen a lot of effort towards node 10 support, but I'm not sure how far this is.

I just did a quick test, and there is still something to to on the Theia side.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there is a PR @kittaakos is working on to make Theia run with node 10.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for bumping. We can handle it in Theia's .gitpod.yml


RUN curl https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash
RUN /bin/bash -l -c "\
Expand Down