Copy images using OCI manifests #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
utam0k
reviewed
Oct 13, 2022
| @@ -72,7 +72,7 @@ jobs: | |||
| IMAGES=$(cat .github/promote-images.yml | yq '."europe-docker.pkg.dev/gitpod-artifacts/docker-dev"."images-by-tag-regex"|keys[]' -r) | |||
| for IMAGE in $IMAGES; | |||
| do | |||
| sudo skopeo copy \ | |||
| sudo skopeo copy --format=oci --dest-oci-accept-uncompressed-layers \ | |||
There was a problem hiding this comment.
I have a question. Why is it worth uncompressing?
There was a problem hiding this comment.
Why is it worth uncompressing?
We are just copying something. If we want to compress it, let's do that during the build, not the copy.
At this point, this should be dumb.
There was a problem hiding this comment.
for research?
This is the first step to anything interesting in the future, like SOCI
There was a problem hiding this comment.
I see! Thanks for your explanation 🙏
By the way, can we think of using zstd:chunked?
There was a problem hiding this comment.
By the way, can we think of using zstd:chunked?
Yes? But I think this is missing in buildkit opencontainers/image-spec#803
utam0k
approved these changes
Oct 13, 2022
|
Merging. I want to see if there's any failure during the push to dockerhub and also check the change in mediaType. |
|
@utam0k please open a PR in dazzle to add |
Sure! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use OCI manifests for the publication of the images instead of docker.
The goal here is to enable the research of lazy snapshotters.
How to test