Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Always use UTF-8 for metadata files in setup.py
This passes `encoding="utf-8"` to the `open` calls in setup.py, so the readme, version, and requirements files are always read as UTF-8, even on systems whose locale is not UTF-8, as is typically the case on many Windows systems for non-European languages. The specific problem was caused by the README.md file. The requirements files are less likely to contain characters not in the ASCII subset, though they could come to contain them, at least in comments. The VERSION file is even less likely to ever contain such characters. Nonetheless, for consistency, because it is a best practice, and because it appears to be the intent of the existing code, encoding="utf=8" is added for opening all of them. This change is tested on a system whose locale uses Windows code page 936. Editable installation, as well as the other affected ways of installing (and building) described in #1747, are now working. (Installing from a pre-built wheel was never affected.)
- Loading branch information