Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitPython's Standard License Header Comments to Shell Scripts #1907

Conversation

DaveLak
Copy link
Contributor

@DaveLak DaveLak commented Apr 22, 2024

This is related to follow-ups for unresolved review comments in #1901. Specifically: #1901 (comment)

See the commit messages for 2b0a969 and b021a76 for further details.

CC @EliahKagan for visibility

DaveLak added 2 commits April 22, 2024 16:36
These files are already BSD-3-Clause even without the headers, but
adding these comments and the `LICENSE-BSD` symlink to the root level
`LICENSE` file are helpful to reinforce that there are only two
particular files in the `fuzzing/` that are not under BSD-3-Clause.

See:
gitpython-developers#1901 (comment)
While discussing adding similar license comments to the shell scripts
introduced in PR gitpython-developers#1901, it was noticed that the shell scripts in the
repository root directory did not have such comments and suggested that
we could add them when the scripts in the `fuzzing/` directory were
updated, so this commit does just that.

See:
gitpython-developers#1901 (comment)
@DaveLak DaveLak mentioned this pull request Apr 22, 2024
11 tasks
Copy link
Contributor

@EliahKagan EliahKagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@Byron Byron merged commit fa2b2d6 into gitpython-developers:main Apr 23, 2024
26 checks passed
@DaveLak DaveLak deleted the add-license-header-comments-to-shell-scripts branch April 29, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants