Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In
__init__.py
there is a loop that invokes__import__
here:gitdb/gitdb/__init__.py
Line 13 in 3415e08
Since the loop only has one item this PR convert refactors it to use the standard
import
.Why
Some tooling only works with modules to be imported via
import
as the packages names are resolve-able without executing code, which__import__
prevents.Possible Changes
If it is desired to have
smmap
added intoglobals()
of__init__.py
; I can remove thedel smmap
line. Right now it is there because__import__
, whichimport
is replacing, does not addsmmap
toglobals()