Add Cairo verify command #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonmeso
reviewed
Jan 23, 2024
| The job size, model id, and version id can be optionally specified. | ||
| """ | ||
| echo = Echo() | ||
| if not model_id or not version_id: |
There was a problem hiding this comment.
I'll say that model_id and version_id are only needed if we are using proof_id or the user wants to link the proof to a specific version.
Sometimes the user just might want to proof something that its not related to a version, maybe a proof that he has created.
wdty?
Gonmeso
previously approved these changes
Jan 23, 2024
Gonmeso
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.