Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct missing method implementation #401

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Correct missing method implementation #401

merged 1 commit into from
Apr 9, 2024

Conversation

gjtorikian
Copy link
Owner

@gjtorikian gjtorikian commented Apr 9, 2024 •
edited
Loading

Closes #400

@gjtorikian gjtorikian enabled auto-merge April 9, 2024 12:11
@gjtorikian gjtorikian merged commit 20c179b into main Apr 9, 2024
3 checks passed
@gjtorikian gjtorikian deleted the rework-pipeline-feed branch April 9, 2024 12:12
@aki77
Copy link

aki77 commented Apr 9, 2024

Thank you for addressing this issue.
However, I have some concerns regarding the approach taken to fix it.
It seems like the changes were made somewhat hastily just to prevent errors for now, which might not be the most optimal solution.
Additionally, I've noticed that the context passed in the initialize method and the one passed in the call method are now completely separate, which raises questions about the underlying reasoning for this modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when passing instance of TextFilter class to text_filters option
2 participants
@gjtorikian @aki77