Merge pull request #238 from gjtorikian/no-alphabets

Ignore cases when checking internal IDs

.travis.yml

@@ -1,6 +1,5 @@
 language: ruby
 rvm:
-  - 1.9
   - 2.0
   - 2.1
   - 2.2
@@ -10,3 +9,6 @@ env:
 
 sudo: false
 cache: bundler
+
+git:
+  depth: 10

lib/html/proofer.rb

@@ -9,6 +9,7 @@ def require_all(path)
 require_all 'proofer/check_runner'
 require_all 'proofer/checks'
 require_relative './proofer/utils'
+require_relative './proofer/xpathfunctions'
 
 require 'parallel'
 

lib/html/proofer/checks/links.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 class LinkCheckable < ::HTML::Proofer::Checkable
 
   def href
@@ -101,7 +100,8 @@ def external_link_check(link)
   end
 
   def hash_check(html, href_hash)
-    html.xpath("//*[@id='#{href_hash}']", "//*[@name='#{href_hash}']").length > 0
+    html.xpath("//*[case_insensitive_equals(@id, '#{href_hash}')]", \
+               "//*[case_insensitive_equals(@name, '#{href_hash}')]", HTML::Proofer::XpathFunctions.new).length > 0
   end
 
 end

lib/html/proofer/xpathfunctions.rb

@@ -0,0 +1,9 @@
+module HTML
+  class Proofer
+    class XpathFunctions
+      def case_insensitive_equals(node_set, str_to_match)
+        node_set.find_all { |node| node.to_s.downcase == str_to_match.to_s.downcase }
+      end
+    end
+  end
+end

spec/html/proofer/fixtures/links/ignores_cases.html

@@ -0,0 +1,3 @@
+<a href="#Android">Android</a>
+
+<h2 id="android">Android</h2>

spec/html/proofer/links_spec.rb

@@ -361,4 +361,10 @@
     proofer = run_proofer(fixture)
     expect(proofer.failed_tests).to eq []
   end
+
+  it 'does not complain for internal links with mismatched cases' do
+    fixture = "#{FIXTURES_DIR}/links/ignores_cases.html"
+    proofer = run_proofer(fixture)
+    expect(proofer.failed_tests).to eq []
+  end
 end