Merge pull request #159 from gjtorikian/support-attributes-with-dash

Translate attributes with dashes into underscores

lib/html/proofer/checkable.rb

@@ -10,11 +10,9 @@ class Checkable
 
       def initialize(obj, check)
         obj.attributes.each_pair do |attribute, value|
-          next if attribute == 'data-proofer-ignore' # TODO: not quite sure why this doesn't work
-          instance_variable_set("@#{attribute}".to_sym, value.value)
+          instance_variable_set("@#{attribute.tr('-', '_')}".to_sym, value.value)
         end
 
-        @data_ignore_proofer = obj['data-proofer-ignore']
         @content = obj.content
         @check = check
         @checked_paths = {}
@@ -66,7 +64,7 @@ def non_http_remote?
       end
 
       def ignore?
-        return true if @data_ignore_proofer
+        return true if @data_proofer_ignore
 
         case @type
         when 'FaviconCheckable'

spec/html/proofer/fixtures/links/attributeWithDash.html

@@ -0,0 +1,8 @@
+<a
+  id="electriccars"
+  data-columns="3"
+  data-index-number="12314"
+  data-parent="cars"
+  href="https://www.github.com">
+Hullo
+</a>

spec/html/proofer/links_spec.rb

@@ -349,4 +349,10 @@
     proofer = run_proofer(fixture)
     expect(proofer.failed_tests.first).to match(/post.htm\?id=63009224 failed: 404 No error/)
   end
+
+  it 'does not complain for files with attributes containing dashes' do
+    fixture = "#{FIXTURES_DIR}/links/attributeWithDash.html"
+    proofer = run_proofer(fixture)
+    expect(proofer.failed_tests).to eq []
+  end
 end