spec for error handling

gjtorikian · Sep 23, 2018 · d7f1b67 · d7f1b67
1 parent 668fe3a
commit d7f1b67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/html-proofer.rb b/lib/html-proofer.rb
@@ -29,7 +29,11 @@ def parse_json_option(option_name, config)
       if config.strip.empty? then
         {}
       else
-        JSON.parse(config)
+        begin
+          JSON.parse(config)
+        rescue 
+          raise ArgumentError.new("Option '" + option_name + "' did not contain valid JSON.")
+        end
       end
     end
 end

diff --git a/spec/html-proofer/parse_json_option_spec.rb b/spec/html-proofer/parse_json_option_spec.rb
@@ -40,5 +40,6 @@
   end
 
   it 'Throws an error when the json config is not valid json' do
+    expect {HTMLProofer.parse_json_option('testName', 'abc')}.to raise_error(ArgumentError, "Option 'testName' did not contain valid JSON.")
   end
 end