-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read config from _config.yml
when present
#175
Comments
What do you think about that? # _proofer.yml
verbose: true
typhoeus:
ssl_verifyhost: 2 # Rakefile
HTML::Proofer.new("./_site", :config => '_proofer.yml').run The default for the |
I do very much like the idea of making this generic as @penibelst suggests. What if it reads from HTML::Proofer.new("./_site", :config => '_config.yml', :config_key => 'proofer' ).run # _config.yaml
baseurl: ''
proofer:
- verbose: true
- typhoeus:
ssl_verifyhost: 2 Not sure if that's overly complicated. I'm not often a fan of introducing a new top-level file in projects (_proofer.yml) for people that do not like them. |
I think it is. We should not motivate people to pollute foreign configuration files. |
Fair enough, fair enough. I think a _proofer.yml is fine. |
|
@nschonni I agree. And I like the dot at start. We could make the config feature only available for the binary. htmlproof --config .myproofer.yml The default config should have the same name as the binary |
In case this refers to jekyll: I created a minimalistic jekyll plugin wrapping html-proofer. The plugin can be configured using jekyll's |
This sounds great. This would be a really valuable feature. |
Does not complete successfully with github-pages gem group on travis-ci github/pages-gem/issues/626 gjtorikian/html-proofer/issues/175
Won't support myself, but PRs accepted |
I taught my Rakefile to read the
html_proofer
property of my_config.yml
file.Would be awesome to support that automatically, if a
_config.yml
file is present.The text was updated successfully, but these errors were encountered: