Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html-proofer depends on nokogumbo #660

Closed
am-root opened this issue Oct 31, 2021 · 4 comments
Closed

html-proofer depends on nokogumbo #660

am-root opened this issue Oct 31, 2021 · 4 comments

Comments

@am-root
Copy link

am-root commented Oct 31, 2021

Hello, I am installing the dependencies from this repo. Generated and cloned the repo, ran bundle when I encountered this issue. I tried to install nokogumbo using gem install nokogumbo

ruby version:
ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux-gnu]

nokogiri version:
nokogiri: version: 1.12.5

OS version:
Linux parrot 5.14.0-2parrot1-amd64 #1 SMP Debian 5.14.6-2parrot1 (2021-09-25) x86_64 GNU/Linux

-----Error starts------

Fetching nokogumbo 2.0.5
Installing nokogumbo 2.0.5 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
current directory: /tmp/bundler20211031-7207-3pl4hpnokogumbo-2.0.5/gems/nokogumbo-2.0.5/ext/nokogumbo
/usr/bin/ruby2.7 -I /usr/lib/ruby/vendor_ruby -r ./siteconf20211031-7207-1vgand7.rb extconf.rb
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary libraries and/or headers. Check the mkmf.log file for more details. You may need configuration options.
Provided configuration options:
--with-opt-dir
--without-opt-dir
--with-opt-include
--without-opt-include=${opt-dir}/include
--with-opt-lib
--without-opt-lib=${opt-dir}/lib
--with-make-prog
--without-make-prog
--srcdir=.
--curdir
--ruby=/usr/bin/$(RUBY_BASE_NAME)2.7
/usr/lib/ruby/vendor_ruby/nokogiri/xml/xpath/syntax_error.rb:4:in module:XML': XPath is not a class (TypeError)
/var/lib/gems/2.7.0/gems/nokogiri-1.12.5-x86_64-linux/lib/nokogiri/2.7/nokogiri.so:0: previous definition of XPath was here
from /usr/lib/ruby/vendor_ruby/nokogiri/xml/xpath/syntax_error.rb:3:in module:Nokogiri'
from /usr/lib/ruby/vendor_ruby/nokogiri/xml/xpath/syntax_error.rb:2:in <top (required)>'
from /usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb:96:in require'
from /usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb:96:in require'
from /usr/lib/ruby/vendor_ruby/nokogiri/xml/xpath.rb:2:in <top (required)>'
from /usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb:96:in require'
from /usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb:96:in require'
from /usr/lib/ruby/vendor_ruby/nokogiri/xml.rb:21:in <top (required)>'
from /usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb:96:in require'
from /usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb:96:in require'
from /usr/lib/ruby/vendor_ruby/nokogiri.rb:36:in <top (required)>'
from /usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb:85:in require'
from /usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb:85:in require'
from extconf.rb:4:in

'
extconf failed, exit code 1

Gem files will remain installed in /tmp/bundler20211031-7207-3pl4hpnokogumbo-2.0.5/gems/nokogumbo-2.0.5 for inspection.
Results logged to /tmp/bundler20211031-7207-3pl4hpnokogumbo-2.0.5/extensions/x86_64-linux/2.7.0/nokogumbo-2.0.5/gem_make.out

An error occurred while installing nokogumbo (2.0.5), and Bundler cannot continue.
Make sure that gem install nokogumbo -v '2.0.5' --source 'https://rubygems.org/' succeeds before bundling.

In Gemfile:
html-proofer was resolved to 3.19.2, which depends on
nokogumbo

-----Error ends------

Can you please help me resolve this? I am inexperienced and could not find any blog related to this.

@dcrossleyau
Copy link

For applications that depend on html-proofer, the GitHub Dependabot alerts have been notifying about this.

It was fixed here on 2021-08-29 #650 (Replace Nokogumbo with Nokogiri)
but the latest release of html-proofer was 3.19.2 on 2021-06-25

So i gather that a new release of html-proofer would be useful.

@loganpowell
Copy link

I am having the same issue with the Nokogumbo merger causing failures in my build pipeline

@gjtorikian
Copy link
Owner

3.19.3 has been released with this fix.

@loganpowell
Copy link

🙏 thank you 🙏

bsweger added a commit to reichlab/reichlab.github.io that referenced this issue Mar 28, 2024
Starting with version 3.19.3, html-proofer removes its dependency
on the end-of-life nokogumbo library and replaces it with nokogirl.
gjtorikian/html-proofer#660

Front_matter_parser 1.0.1 fixes an error with newer versios of Ruby
https://github.com/waiting-for-dev/front_matter_parser/blob/main/CHANGELOG.md#101---2021-07-20

The base64 and csv gems will no longer be included with Ruby, so add to Gemfile
to ensure they will be installed

Update bundler to fix up some warnings/errors and update the rest of the packages

Update to Ruby 3.3

Ruby 3.0 will no longer be supported as of 2024-03-31, so let's get
it upgraded.

research.rb and teaching.rb are included in this changeset because
they were using File.exists, which is invalid syntax as of Ruby 3.2

ignore env helper files
bsweger added a commit to reichlab/reichlab.github.io that referenced this issue Jun 20, 2024
Starting with version 3.19.3, html-proofer removes its dependency
on the end-of-life nokogumbo library and replaces it with nokogirl.
gjtorikian/html-proofer#660

Front_matter_parser 1.0.1 fixes an error with newer versios of Ruby
https://github.com/waiting-for-dev/front_matter_parser/blob/main/CHANGELOG.md#101---2021-07-20

The base64 and csv gems will no longer be included with Ruby, so add to Gemfile
to ensure they will be installed

Update bundler to fix up some warnings/errors and update the rest of the packages

Update to Ruby 3.3

Ruby 3.0 will no longer be supported as of 2024-03-31, so let's get
it upgraded.

research.rb and teaching.rb are included in this changeset because
they were using File.exists, which is invalid syntax as of Ruby 3.2

ignore env helper files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants