Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious "link has no href attribute" error #79

Closed
parkr opened this issue Aug 6, 2014 · 1 comment · Fixed by #80
Closed

Mysterious "link has no href attribute" error #79

parkr opened this issue Aug 6, 2014 · 1 comment · Fixed by #80

Comments

@parkr
Copy link
Contributor

parkr commented Aug 6, 2014

I just started testing one of my sites
and it turns out there's an issue with a link having no href attribute. Or does
that mean it's an a tag that has no href attribute?

It's a confusing error – could it be elaborated upon?

@gjtorikian
Copy link
Owner

Yes, it means an a tag without an href. If I had to guess, this line is throwing Proofer off: <a href="{{ site.github.repository_url }}" class="github">GitHub&nbsp;</a>

Interesting use case. Since the metadata doesn't exist, it renders as href="". You could add data-proofer-ignore to skip it, but I wonder if that's too heavy handed a solution. You or @benbalter have any ideas?

Regardless, since we do now check link tags, I'll update the message to make it clear this is for an anchor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants