Refactor html-proofer #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| options[:verbose] = opts['verbose'] unless opts['verbose'].nil? | ||
| options[:directory_index_file] = opts['directory_index_file'] unless opts['directory_index_file'].nil? | ||
| options[:validate_html] = opts['validate_html'] unless opts['validate_html'].nil? | ||
| options[:check_external_hash] = opts['check_external_hash'] unless opts['check_external_hash'].nil? |
There was a problem hiding this comment.
ugh probably. I was thinking about removing the bin entirely but I guess that's Not The Right Thing To Do ™️.
|
❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ |
|
Really nice. With smaller chunks we could sometimes test classes instead of the whole thing. I’ve added tests for the new Utils class in 7006132. |
Closed
|
Nice run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors html-proofer into much more manageable and smaller chunks. Notably, it:
HTML::Proofer::Checks::Checkto a more saneHTML::Proofer::Runner.It also namespaces Typheous/Hydra option passing; hence this will be a major version bump when merged.
Fixes #131, fixes #114, fixes #129.
Although none of you are under any obligation whatsoever to do so, a review from @penibelst / @benbalter / @parkr might be nice, to make sure I'm not missing something.