Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cgi dependency #167

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Conversation

johnelse
Copy link
Contributor

@johnelse johnelse commented Feb 3, 2015

htmlproof --check-html tries to call CGI.unescape, which is not in scope
at the moment.

`htmlproof --check-html` tries to call CGI.unescape, which is not in scope
at the moment.

Signed-off-by: John Else <john.else@citrix.com>
@gjtorikian
Copy link
Owner

Ugh, thanks!

gjtorikian added a commit that referenced this pull request Feb 3, 2015
@gjtorikian gjtorikian merged commit a77f316 into gjtorikian:master Feb 3, 2015
@doktorbro
Copy link

@gjtorikian I see now the Addressable::URI.unencode method. Should we use it rather and avoid the CGI dependency?

@gjtorikian
Copy link
Owner

Yeah, probably. Mind PRing?

@doktorbro
Copy link

Yeah, probably. Mind PRing?

Done in #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants