Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VCR to record and replay HTTP interactions #227

Merged
merged 6 commits into from
Jul 12, 2015
Merged

Conversation

gjtorikian
Copy link
Owner

@penibelst This is more what I had in mind for determining the HTTP interactions. VCR records the interaction once, then replays them. This also speeds up the test suite as no HTTP calls are actually made anymore for old tests. (New ones will need to record the interaction once.)

@doktorbro
Copy link

Looks good to me.

Step Before After
install 12.41 13.97
script 19.64 12.40

@@ -7,6 +7,8 @@
<p>Blah blah blah. <a href="https://help.github.com/changing-author-info/">This is another redirect.</a>. </p>

<p>Blah blah blah. <a href="http://timclem.wordpress.com/2012/03/01/mind-the-end-of-your-line/">This is a third redirect.</a>. </p>

<p> <a href="https://github.com/github/repository-sync">and a foruth!</a> </p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fourth?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sense a disturbance in the Force.

gjtorikian added a commit that referenced this pull request Jul 12, 2015
Use VCR to record and replay HTTP interactions
@gjtorikian gjtorikian merged commit 0570516 into master Jul 12, 2015
@gjtorikian gjtorikian deleted the vee-sea-arr branch July 12, 2015 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants