htmlproofer should set status codes to ints #319
Conversation
|
I like this. Thanks! |
| @@ -71,6 +71,8 @@ Mercenary.program(:htmlproofer) do |p| | |||
|
|
|||
| options[:cache] = {} | |||
| options[:cache][:timeframe] = opts['timeframe'] unless opts['timeframe'].nil? | |||
|
|
|||
| options[:http_status_ignore] = Array(options[:http_status_ignore]).map(&:to_i) | |||
There was a problem hiding this comment.
This will need to be options[:http_status_ignore].split(',') to get the array for multiple codes.
There was a problem hiding this comment.
You specify it as an Array so OptionsParser will give it to you as such. I tested it locally and it works. 😄
There was a problem hiding this comment.
Can you add a test for it? In irb at least I get:
Array("421, 422").map(&:to_i)
=> [421]
irb(main):005:0>
https://github.com/gjtorikian/html-proofer/blob/4434b7eecb19d869c59c92e6480661d18866253c/spec/html-proofer/command_spec.rb is where all the bin tests go. ❤️
There was a problem hiding this comment.
@gjtorikian the input isn't "421, 422", it's ["421", "422"] I'll add a test.
There was a problem hiding this comment.
Scratch that. @gjtorikian I can't use both VCR and the executable because the executable doesn't share the same Ruby env as the specs.
Trust that this line does what I'm saying it does?
|
Meh, I trust you. Sorry for the delay. |
|
❤️ |
ignored_status_codes.include? 429will be false ifignored_status_codes = ["429"]