Implement Open Graph #359
Implement Open Graph #359
Conversation
…nto opengraph Conflicts: bin/htmlproofer lib/html/proofer.rb lib/html/proofer/configuration.rb
|
I just need to address #282 (comment) . |
|
Working now, I still need to address #282 (comment) and any other comments. |
|
Missing tests added. |
|
I think this is ready for review now @gjtorikian . The failing test just seems to be failing on your Travis, it just worked fine on mine for the same commit (possibly a timeout): |
|
Wow, this looks absolutely perfect. 😍
Indeed, I can't reproduce it. I'm going to go ahead and merge anyway. Thank you! |
|
I can't take most of the credit, I just tweaked @penibelst 's work to deal with the refactoring in html-proofer and added a few more tests. Indeed the merge ran fine: I normally just re-run Travis when I hit those issues, but couldn't on yours, I guess as I don't have admin rights on your repo. |
This should close #111. Based on @penibelst 's work in #182 and #282 .