Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Access-Control-Allow-Origin: * when check sri #463

Closed
wants to merge 2 commits into from

Conversation

ilyalyo
Copy link
Contributor

@ilyalyo ilyalyo commented Dec 15, 2017

issue #417

@codecov-io
Copy link

codecov-io commented Dec 21, 2017

Codecov Report

Merging #463 into master will decrease coverage by 0.37%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   98.53%   98.16%   -0.38%     
==========================================
  Files          27       27              
  Lines        1777     1795      +18     
==========================================
+ Hits         1751     1762      +11     
- Misses         26       33       +7
Impacted Files Coverage Δ
lib/html-proofer/url_validator.rb 97.79% <100%> (+0.04%) ⬆️
lib/html-proofer/check/links.rb 98.75% <100%> (ø) ⬆️
lib/html-proofer/runner.rb 93.75% <45.45%> (-5.28%) ⬇️
lib/html-proofer/check.rb 92.85% <88.88%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac4d60...d67baf3. Read the comment docs.

@hanzei
Copy link

hanzei commented Jul 24, 2018

What is the status of this PR?

@hanzei
Copy link

hanzei commented Dec 13, 2018

Ping @gjtorikian

@gjtorikian
Copy link
Owner

This PR will need tests. It seems that fixture files were added, but no tests for them.

@hanzei
Copy link

hanzei commented Jan 9, 2019

@ilyalyo Could you please add some test to your changes?

@gjtorikian gjtorikian closed this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants