Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort issues #52

Merged
merged 3 commits into from
Jul 15, 2014
Merged

Sort issues #52

merged 3 commits into from
Jul 15, 2014

Conversation

doktorbro
Copy link

Now external issues come out in random order:

#0
_site/docs/history/index.html: External link https://github.com/bahuvrihi failed: 404 No error
#0
_site/docs/history/index.html: External link https://github.com/gcnovus failed: 404 No error
#1
_site/docs/deployment-methods/index.html: External link https://github.com/rtomakyo/shotgun/ failed: 404 No error
#2
_site/docs/extras/index.html: External link http://kramdown.rubyforge.org/ failed: got a time out
#1
_site/docs/deployment-methods/index.html: External link http://net-ssh.rubyforge.org/ failed: got a time out
#3
_site/docs/plugins/index.html: External link http://ultraviolet.rubyforge.org/ failed: got a time out
#2
_site/docs/extras/index.html: External link http://kramdown.rubyforge.org/options.html failed: got a time out
#3
_site/docs/plugins/index.html: External link http://saswatpadhi.github.io/ failed: 404 No error

Sorted issues would support the cleaning workflow. It’s handy.

@parkr
Copy link
Contributor

parkr commented Jul 14, 2014

IMHO, it would be more performant to sort only when fetching the issues. Sorting an array feels like a presentation domain issue rather than a data issue.

@doktorbro
Copy link
Author

@parkr You are right. I didn’t found the array output on the first attempt. Fixed now.

gjtorikian added a commit that referenced this pull request Jul 15, 2014
@gjtorikian gjtorikian merged commit 8c4dc03 into gjtorikian:master Jul 15, 2014
@gjtorikian
Copy link
Owner

🌵

@doktorbro doktorbro deleted the sort-issues branch July 15, 2014 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants