Add flag to allow no-email mailto links #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defaults to erroring about mailto links with email addresses for backwards compatibility, however I'd be equally happy to invert this and have the default allow the no-email case. Fixes gjtorikian#552.
|
Thanks for the contribution! To match consistency with other options, can you rename this to |
Sure, I wasn't sure which way around the name should be (there seem to be some both ways around). I'd originally thought to use "empty" in the name, but decided against in case it implied that |
|
@gjtorikian I'm not sure what the lint failure here means (I don't appear to have changed the file it's in); I'm not usually a ruby developer. Could you suggest what I need to do to fix it? |
|
Don't worry about it--I fixed it. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults to erroring about
mailtolinks with email addresses for backwards compatibility, however I'd be equally happy to invert this and have the default allow the no-email case.Fixes #552.