Srcsets - better handling of multiple srcsets #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, thanks very much! Releasing this as a patch update right now. |
|
Looks like this still leaves a few issues. 'img' tags with multiple pixel density srcset attributes now work correctly - but 'source' tags don't. I think this can be fixed by switching 'source' tags to being handled by the code in images.rb rather than the code in links.rb. I'm happy to contribute a PR to do this. Does that sound like a sensible approach to you? If so I'll get a second PR going... |
|
Sure, I can review the change and see what makes most sense then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix to #724 didn't handle this situation:
srcset="test.webp 1.5x, test2.webp 2x"This PR should fix this, add a new test case, and hopefully remove some code duplication as a nice bonus.