Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should run when a draft PR gets marked as ready for review #288

Closed
paddyroddy opened this issue Sep 27, 2024 · 0 comments · Fixed by #289
Closed

CI should run when a draft PR gets marked as ready for review #288

paddyroddy opened this issue Sep 27, 2024 · 0 comments · Fixed by #289
Assignees
@paddyroddy
Labels
bug Something isn't working

Comments

@paddyroddy
Copy link
Member

Describe the Bug

Some crucial bits are missing in the on section of the GitHub Actions workflows. So if a PR is marked as draft, the CI will never run.

To Reproduce

import glass
...

Expected Behaviour

No response

Actual Behaviour

No response

Version In Use

2024.2.dev5+g27fa141.d20240911

Additional Context

- Python version:
- Operating system:
@paddyroddy paddyroddy added the bug Something isn't working label Sep 27, 2024
@paddyroddy paddyroddy self-assigned this Sep 27, 2024
paddyroddy added a commit that referenced this issue Sep 27, 2024
@paddyroddy
gh-288: run CI when a draft PR is marked as ready
938bd18 
Fixes #288. Currently a PR is never tested the moment it gets
marked as draft. The idea behind not running in draft is to
limit CI use, but we need to ensure everything is ran before
merging to `main`.
@paddyroddy paddyroddy mentioned this issue Sep 27, 2024
Merged
paddyroddy added a commit that referenced this issue Sep 27, 2024
@paddyroddy
gh-288: run CI when a draft PR is marked as ready (#289)
94a4718 
Fixes #288. Currently a PR is never tested the moment it gets marked as
draft. The idea behind not running in draft is to limit CI use, but we
need to ensure everything is ran before merging to `main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-288: run CI when a draft PR is marked as ready glass-dev/glass
1 participant
@paddyroddy