gh-231: add ruff linting to pre-commit
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
enhancement
paddyroddy
commented
Sep 18, 2024
paddyroddy
commented
Sep 18, 2024
paddyroddy
commented
Sep 18, 2024
| @@ -2,3 +2,4 @@ | |||
| b42067f6776dcd763827000d585a88e071b78af3 | |||
| # applied prettier - https://github.com/glass-dev/glass/pull/227 | |||
| f9bac62f497a7288aa71fd4dbd948945c37f854e | |||
| # applied ruff-linting - https://github.com/glass-dev/glass/pull/232 | |||
There was a problem hiding this comment.
@Saransh-cpp when this is merged can you add the commit hash underneath?
paddyroddy
commented
Sep 18, 2024
Comment on lines
+98
to
+109
| "ANN001", # TODO: missing-type-function-argument | ||
| "ANN002", # TODO: missing-type-args | ||
| "ANN003", # TODO: missing-type-kwargs | ||
| "ANN201", # TODO: missing-return-type-undocumented-public-function | ||
| "COM812", # missing-trailing-comma (ruff-format recommended) | ||
| "D203", # one-blank-line-before-class | ||
| "D212", # blank-line-before-class | ||
| "ERA001", # TODO: commented-out-code | ||
| "ISC001", # single-line-implicit-string-concatenation (ruff-format recommended) | ||
| "NPY002", # TODO: numpy-legacy-random | ||
| "NPY201", # TODO: numpy2-deprecation | ||
| "RUF003", # ambiguous-unicode-character-comment |
There was a problem hiding this comment.
All the TODO can gradually be fixed, not doing now for the sake of time
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
This was referenced Sep 18, 2024
|
Okay, this is ready, always fiddly to add this kind of thing! Please review carefully as there are a fair few changes. They are generally trivial. I have self-reviewed and everything looks fine, I think. Have raised #248, #249 to follow up. This should probably me merged ASAP as other PRs will conflict with this potentially - and a fair bit of effort to fix. |
ntessore
requested changes
Sep 18, 2024
|
This should be ready to review again! |
Saransh-cpp
approved these changes
Sep 19, 2024
ntessore
approved these changes
Sep 19, 2024
|
Thanks for taking over whilst I was away @Saransh-cpp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
rufflinting and turn on as many rules as possible. However, I will turn off many and not spend too much time fixing them. In a perfect world, we will try and fix as many of these as possible - as they will generally help with maintenance in the long term.Closes: #231
Refs: #170