Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-384: rename all internal functions to trapezoid over trapz #392

Open
wants to merge 9 commits into
base: paddy/issue-163
Choose a base branch
from
Open

gh-384: rename all internal functions to trapezoid over trapz #392

wants to merge 9 commits into from

Conversation

paddyroddy
Copy link
Member

Closes #384. Blocked by #391.

Keeping in line with NumPy v2 renaming np.trap to np.trapezoid. It was agreed to change the internal name of functions to avoid potential confusion.

@paddyroddy paddyroddy added the api An (incompatible) API change label Oct 30, 2024
@paddyroddy paddyroddy self-assigned this Oct 30, 2024
@paddyroddy paddyroddy added the blocked The issue or pull request is blocked by something label Oct 30, 2024
@paddyroddy paddyroddy linked an issue Oct 30, 2024 that may be closed by this pull request
Change all functions with trapz in the name to trapezoid in line with NumPy v2 #384
Open
Saransh-cpp
Saransh-cpp reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! No backwards compatibility required!

Saransh-cpp
Saransh-cpp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forgot to approve, just commented by mistake

@paddyroddy paddyroddy mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

@ntessore ntessore Awaiting requested review from ntessore

Assignees

@paddyroddy paddyroddy

Labels
api An (incompatible) API change blocked The issue or pull request is blocked by something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change all functions with trapz in the name to trapezoid in line with NumPy v2
2 participants
@paddyroddy @Saransh-cpp