gh-124: use cosmology.api over the cosmology package
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
enhancement
paddyroddy
commented
Nov 7, 2024
| @@ -49,6 +49,7 @@ docs = [ | |||
| ] | |||
| examples = [ | |||
| "camb", | |||
| "cosmology", | |||
There was a problem hiding this comment.
cosmology is still used in the notebooks currently
paddyroddy
commented
Nov 8, 2024
| @@ -31,14 +31,14 @@ def shells() -> list[RadialWindow]: | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def cosmo() -> Cosmology: | |||
| def cosmo() -> StandardCosmology: | |||
| class MockCosmology: | |||
There was a problem hiding this comment.
I've changed the mock to match the names from cosmology.api, hence the noqa
paddyroddy
commented
Nov 8, 2024
glass/galaxies.py
Outdated
Comment on lines
18
to
20
| Intrinsic alignments | ||
| -------------------- | ||
| .. autofunction:: kappa_ia_nla |
There was a problem hiding this comment.
I have reverted #21 as I believe it is broken/needs testing. Don't want to waste time porting.
paddyroddy
commented
Nov 8, 2024
| def ef(self, z: npt.NDArray[np.float64]) -> npt.NDArray[np.float64]: | ||
| return (self.omega_m * (1 + z) ** 3 + 1 - self.omega_m) ** 0.5 | ||
| def H_over_H0(self, z: npt.NDArray[np.float64]) -> npt.NDArray[np.float64]: # noqa: N802 | ||
| return (self.Omega_m0 * (1 + z) ** 3 + 1 - self.Omega_m0) ** 0.5 | ||
|
|
||
| def xm( |
There was a problem hiding this comment.
There is no equivalently named function in cosmology.api. In practice, this would be
cosmology.api.Standard.Cosmology.transverse_comoving_distance(z) / (cosmology.api.CosmologyConstantsNamespace.c / cosmology.api.Standard.Cosmology.H0)
paddyroddy
commented
Nov 8, 2024
Comment on lines
+334
to
+335
| x2 = self.x3 | ||
| self.x3 = self.cosmo.transverse_comoving_distance(self.z3) / hubble_length |
There was a problem hiding this comment.
I've split these so the line isn't really long
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124. Use the improved
cosmology.apipackage throughout the code.