Node version 10 breaking change causing false positive connection end msg

[glebec]

Getting connection closed before res end/flush on every single request in Node v10+.

[ronag]

There was a bug related to this in 10.2.0. But it should have been fixed in 10.2.1. What version of node are you experiencing this on?

[glebec]

@ronag 10.3.0.

[ronag]

Yea, you need to remove the close listener on 'finish'. Alternatively you could use req.on('aborted') to achieve what I believe you are looking for.

[glebec]

Yep, I have been looking at the Node changelog. As of this post, the docs still claim that close "indicates that the underlying connection was terminated before response.end() was called or able to flush" – that doesn't appear to be 100% accurate anymore. Removing the close listener upon finish sounds promising, I'll try it later. Thanks, —G.

[ronag]

nodejs/node#21047