ignore_lines keys are not stringified from YAML

[markedmondson]

When using the YML format for scanner configuration like:

  scanners:
  - - "::I18n::Tasks::Scanners::PatternWithScopeScanner"
    - exclude:
      - "*.rb"
      ignore_lines:
        opal: ^\s*#(?!\si18n-tasks-use)
        haml: ^\s*-\\s*#(?!\si18n-tasks-use)
        coffee: ^\s*#(?!\si18n-tasks-use)

The ignore_lines keys are not stringified, therefore when they hit the pattern scanner, they're not found.

The fix is as simple as: markedmondson@17925c4

[glebm]

The keys in the example you've given are already strings:

> require 'yaml'; YAML.load 'x: 1'
 => {"x"=>1}

> YAML.load <<-'YAML'
scanners:
- - "::I18n::Tasks::Scanners::PatternWithScopeScanner"
  - exclude:
    - "*.rb"
    ignore_lines:
      opal: ^\s*#(?!\si18n-tasks-use)
      haml: ^\s*-\\s*#(?!\si18n-tasks-use)
      coffee: ^\s*#(?!\si18n-tasks-use)
YAML
 => {"scanners"=>[["::I18n::Tasks::Scanners::PatternWithScopeScanner", {"exclude"=>["*.rb"], "ignore_lines"=>{"opal"=>"^\\s*#(?!\\si18n-tasks-use)", "haml"=>"^\\s*-\\\\s*#(?!\\si18n-tasks-use)", "coffee"=>"^\\s*#(?!\\si18n-tasks-use)"}}]]}
> YAML
 => Psych

[markedmondson]

I thought the same thing so had to double check. A test case could probably be written around this but here's an awkward gif to show it.

[glebm]

Ah, perhaps it's because of this:

i18n-tasks/lib/i18n/tasks/used_keys.rb

Line 88 in e8db4a1

conf = (config[:search] || {}).deep_symbolize_keys

[markedmondson]

Aha, good spot, always easier for someone familiar with the codebase to find the potential issue quicker :)

Do you want me to try and add a PR? Would you prefer a solution around the config or the initializer?

[glebm]

Your current solution (ext.to_s) seems good to me, please send a PR! Thanks

[glebm]

Actually, scratch that, I'll fix it in a way that works for scanners other than pattern scanners

[glebm]

Ah, other scanners don't have that setting

[markedmondson]

Great - thanks for the prompt response!

[glebm]

Released v0.9.6!