Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dash in locale filenames when merging data #467

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

sylvieed
Copy link
Contributor

@sylvieed sylvieed commented Aug 5, 2022

A project I'm working on uses dashes in locale filenames (i.e. user-en.yml instead of user.en.yml), which was causing i18n-tasks to not be able to write to the files properly (even after editing the write setting in config/i18n-tasks.yml).

This adds - as a valid character before the #{locale} part of filenames.

@sylvieed
Copy link
Contributor Author

@benwbrum @saracarl when this and #469 are merged we can switch our Gemfile back to this instead of the fork

@glebm glebm merged commit baf9dd1 into glebm:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants