Fix left shift of negative value in MIPSCodeUtils

Fixes a benign UBSAN error to improve the signal-to-noise ratio of UBSAN errors. Fixes hrydgard#14015
glebm · Jan 30, 2021 · c176856 · c176856
1 parent c251d69
commit c176856
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Core/MIPS/MIPSCodeUtils.cpp b/Core/MIPS/MIPSCodeUtils.cpp
@@ -55,7 +55,7 @@ namespace MIPSCodeUtils
 			MIPSInfo info = MIPSGetInfo(op);
 			if (info & IS_CONDBRANCH)
 			{
-				return addr + 4 + ((signed short)(op&0xFFFF)<<2);
+				return addr + 4 + ((signed short)((op&0xFFFF)<<2));
 			}
 			else
 				return INVALIDTARGET;
@@ -77,7 +77,7 @@ namespace MIPSCodeUtils
 			MIPSInfo info = MIPSGetInfo(op);
 			if ((info & IS_CONDBRANCH) && !(info & OUT_RA))
 			{
-				return addr + 4 + ((signed short)(op&0xFFFF)<<2);
+				return addr + 4 + ((signed short)((op&0xFFFF)<<2));
 			}
 			else
 				return INVALIDTARGET;
@@ -125,7 +125,7 @@ namespace MIPSCodeUtils
 				}
 
 				if (sure && takeBranch)
-					return addr + 4 + ((signed short)(op&0xFFFF)<<2);
+					return addr + 4 + ((signed short)((op&0xFFFF)<<2));
 				else if (sure && !takeBranch)
 					return addr + 8;
 				else