use for loop with rev iterator in wake_all

glebpom · Aug 23, 2021 · 905dc93 · 905dc93
1 parent 7a55899
commit 905dc93
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/tokio/src/util/wake_list.rs b/tokio/src/util/wake_list.rs
@@ -30,12 +30,13 @@ impl WakeList {
     }
 
     pub(crate) fn wake_all(&mut self) {
-        assert!(self.curr <= NUM_WAKERS);
-        while self.curr > 0 {
-            self.curr -= 1;
-            let waker = unsafe { ptr::read(self.inner[self.curr].as_mut_ptr()) };
+        debug_assert!(self.curr <= NUM_WAKERS);
+
+        for waker in self.inner[..self.curr].iter_mut().rev() {
+            let waker = unsafe { std::ptr::read(waker.as_mut_ptr()) };
             waker.wake();
         }
+        self.curr = 0;
     }
 }