strip \r and \n when reading the file /etc/host_hostname #335
Conversation
There was a problem hiding this comment.
would be great if there was a test to cover this. @nvanheuverzwijn do you have a few minutes to add that?
|
@michaelshobbs Will do. However, testing this might be difficult because of the hardcoded filename. I will make something up. |
|
@michaelshobbs Done. Waiting for your feedback. |
| t.Fatal(err) | ||
| } | ||
| done := make(chan string) | ||
| addr, sock, srvWG := startServer("tcp", "", done) |
There was a problem hiding this comment.
looks like that broke the reconnect test. No need to spin up the server. I'd just move the hostname logic to it's own function and test that specifically.
There was a problem hiding this comment.
Hey, I'm sorry, I really don't have time to do this. Maybe someone with more experience in go should do this.
There was a problem hiding this comment.
No worries. I'll take it from here. Thanks for the initial contribution!
|
Duplicate #338 |
related to #329