Update puppeteer, node (for perf testing), and the setup script which…

… launches tracerbench (#1628) * Begin * when-to-run-penf-checks is too smart * Specify chrome version * Try chrome 128 * bump node version * Node 20.18 * Update puppeteer, don't install custom chorme * Lockfile * Node 22 * Use puppeteer 20.1.2 * Re-upgrade * Lockfile * Update setup-bench.mjs * Update * Itsworkingitsworking.gif * ope * Update headless value for puppeteer since new types
glimmerjs · Oct 16, 2024 · cc46230 · cc46230
1 parent d436dc4
commit cc46230
Show file tree

Hide file tree

Showing 8 changed files with 215 additions and 178 deletions.
diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml
@@ -39,7 +39,7 @@ jobs:
       - uses: wyvox/action-setup-pnpm@v3
         if: steps.did-change.outputs.changed == 'true'
         with:
-          node-version: '20.1.0'
+          node-version: '22'
 
       - name: RUN
         if: steps.did-change.outputs.changed == 'true'

diff --git a/bin/package.json b/bin/package.json
@@ -18,7 +18,7 @@
     "globby": "^14.0.2",
     "js-yaml": "^4.1.0",
     "mkdirp": "^3.0.1",
-    "puppeteer-chromium-resolver": "^20.0.0",
+    "puppeteer-chromium-resolver": "^23.0.0",
     "tar": "^6.2.0"
   },
   "devDependencies": {

diff --git a/bin/run-tests.mjs b/bin/run-tests.mjs
@@ -1,12 +1,12 @@
-/* eslint-disable no-inline-comments */
+ 
 // @ts-check
 
 import child from 'child_process';
 import { resolve } from 'path';
 import PCR from 'puppeteer-chromium-resolver';
 import { fileURLToPath } from 'url';
 
-// eslint-disable-next-line new-cap
+ 
 const { puppeteer, executablePath } = await PCR({});
 
 const __root = fileURLToPath(new URL('..', import.meta.url));
@@ -44,7 +44,7 @@ await /** @type {Promise<void>} */ (
 console.log('[ci] spawned');
 
 const browser = await puppeteer.launch({
-  headless: 'new',
+  headless: true,
   executablePath,
   args: ['--no-sandbox', '--disable-setuid-sandbox'],
 });

diff --git a/bin/setup-bench.mjs b/bin/setup-bench.mjs
@@ -174,7 +174,7 @@ await new Promise((resolve) => {
 
 try {
   const output =
-    await $`./node_modules/.bin/tracerbench compare --regressionThreshold 25 --sampleTimeout 60 --fidelity ${fidelity} --markers ${markers} --controlURL ${CONTROL_URL} --experimentURL ${EXPERIMENT_URL} --report --headless --cpuThrottleRate ${throttleRate}`;
+    await $`node --single-threaded-gc ./node_modules/tracerbench/bin/run compare --regressionThreshold 25 --sampleTimeout 60 --fidelity ${fidelity} --markers ${markers} --controlURL ${CONTROL_URL} --experimentURL ${EXPERIMENT_URL} --report --headless --cpuThrottleRate ${throttleRate}`;
 
   try {
     fs.writeFileSync(

diff --git a/package.json b/package.json
@@ -90,8 +90,8 @@
     "npm-run-all": "^4.1.5",
     "prettier": "^3.1.0",
     "preval.macro": "^5.0.0",
-    "puppeteer": "^20.1.2",
-    "puppeteer-chromium-resolver": "^20.0.0",
+    "puppeteer": "23.5.3",
+    "puppeteer-chromium-resolver": "^23.0.0",
     "qunit": "^2.19.4",
     "release-it": "^16.2.1",
     "release-plan": "^0.9.2",

diff --git a/packages/@glimmer/syntax/test/plugin-node-test.ts b/packages/@glimmer/syntax/test/plugin-node-test.ts
@@ -48,7 +48,6 @@ test('deprecated program visitor', (assert) => {
     return {
       name: 'plugin',
       visitor: {
-        // eslint-disable-next-line deprecation/deprecation
         Program(node: AST.Program) {
           assert.step(node.type);
         },

diff --git a/packages/@types/puppeteer-chromium-resolver/package.json b/packages/@types/puppeteer-chromium-resolver/package.json
@@ -3,6 +3,6 @@
   "name": "@types/puppeteer-chromium-resolver",
   "types": "index.d.ts",
   "dependencies": {
-    "puppeteer": "^20.1.2"
+    "puppeteer": "23.5.3"
   }
 }