Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppeteer, node (for perf testing), and the setup script which launches tracerbench #1628

Merged
merged 17 commits into from
Oct 16, 2024
Merged
2 changes: 1 addition & 1 deletion .github/workflows/perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- uses: wyvox/action-setup-pnpm@v3
if: steps.did-change.outputs.changed == 'true'
with:
node-version: '20.1.0'
node-version: '22'

- name: RUN
if: steps.did-change.outputs.changed == 'true'
Expand Down
2 changes: 1 addition & 1 deletion bin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"globby": "^14.0.2",
"js-yaml": "^4.1.0",
"mkdirp": "^3.0.1",
"puppeteer-chromium-resolver": "^20.0.0",
"puppeteer-chromium-resolver": "^23.0.0",
"tar": "^6.2.0"
},
"devDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions bin/run-tests.mjs
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/* eslint-disable no-inline-comments */
// @ts-check

import child from 'child_process';
import { resolve } from 'path';
import PCR from 'puppeteer-chromium-resolver';
import { fileURLToPath } from 'url';

// eslint-disable-next-line new-cap
const { puppeteer, executablePath } = await PCR({});

const __root = fileURLToPath(new URL('..', import.meta.url));
Expand Down Expand Up @@ -44,7 +44,7 @@ await /** @type {Promise<void>} */ (
console.log('[ci] spawned');

const browser = await puppeteer.launch({
headless: 'new',
headless: true,
executablePath,
args: ['--no-sandbox', '--disable-setuid-sandbox'],
});
Expand Down
2 changes: 1 addition & 1 deletion bin/setup-bench.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ await new Promise((resolve) => {

try {
const output =
await $`./node_modules/.bin/tracerbench compare --regressionThreshold 25 --sampleTimeout 60 --fidelity ${fidelity} --markers ${markers} --controlURL ${CONTROL_URL} --experimentURL ${EXPERIMENT_URL} --report --headless --cpuThrottleRate ${throttleRate}`;
await $`node --single-threaded-gc ./node_modules/tracerbench/bin/run compare --regressionThreshold 25 --sampleTimeout 60 --fidelity ${fidelity} --markers ${markers} --controlURL ${CONTROL_URL} --experimentURL ${EXPERIMENT_URL} --report --headless --cpuThrottleRate ${throttleRate}`;

try {
fs.writeFileSync(
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@
"npm-run-all": "^4.1.5",
"prettier": "^3.1.0",
"preval.macro": "^5.0.0",
"puppeteer": "^20.1.2",
"puppeteer-chromium-resolver": "^20.0.0",
"puppeteer": "23.5.3",
"puppeteer-chromium-resolver": "^23.0.0",
"qunit": "^2.19.4",
"release-it": "^16.2.1",
"release-plan": "^0.9.2",
Expand Down
1 change: 0 additions & 1 deletion packages/@glimmer/syntax/test/plugin-node-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ test('deprecated program visitor', (assert) => {
return {
name: 'plugin',
visitor: {
// eslint-disable-next-line deprecation/deprecation
Program(node: AST.Program) {
assert.step(node.type);
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@types/puppeteer-chromium-resolver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"name": "@types/puppeteer-chromium-resolver",
"types": "index.d.ts",
"dependencies": {
"puppeteer": "^20.1.2"
"puppeteer": "23.5.3"
}
}
Loading
Loading