Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes up to b716248fc5bde4dc47b8104d092d092d87c50f1a #2837

Merged

Conversation

ClearlyClaire
Copy link

@ClearlyClaire ClearlyClaire commented Sep 6, 2024

Merge upstream changes up to 7335a43

Conflicts

  • app/helpers/application_helper.rb:
    Upstream reworked how CSS classes for the document's body are computed.
    Slight conflict due to glitch-soc's different theming system.
    Updated as upstream did.

Additional changes

  • af6ca96 (fix theming-system-related assertions)

Merge upstream changes up to b716248

No conflict nor anything to port

mjankowski and others added 19 commits September 5, 2024 19:51
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
…oc/merge-upstream

Conflicts:
- `app/helpers/application_helper.rb`:
  Upstream reworked how CSS classes for the document's body are computed.
  Slight conflict due to glitch-soc's different theming system.
  Updated as upstream did.
@ClearlyClaire ClearlyClaire changed the title Merge upstream changes up to 7335a43b6dac0e82c305ce4dec9db4da114c769e Merge upstream changes up to b716248fc5bde4dc47b8104d092d092d87c50f1a Sep 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (dff29c8) to head (5c97ccf).
Report is 349 commits behind head on main.

Files with missing lines Patch % Lines
app/models/admin/account_action.rb 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2837      +/-   ##
==========================================
+ Coverage   87.73%   88.08%   +0.34%     
==========================================
  Files        1117     1119       +2     
  Lines       29724    29782      +58     
  Branches     4779     4790      +11     
==========================================
+ Hits        26078    26233     +155     
+ Misses       3644     3547      -97     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire marked this pull request as ready for review September 6, 2024 19:00
@ClearlyClaire ClearlyClaire merged commit 9dcc680 into glitch-soc:main Sep 7, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants