Fix coding standards (PSR-12)

composer.json

@@ -37,7 +37,8 @@
     "php-http/mock-client": "^1.3",
     "php-http/guzzle7-adapter": "^1.0.0",
     "guzzlehttp/psr7": "^2.1.0",
-    "guzzlehttp/guzzle": "^7.4.1"
+    "guzzlehttp/guzzle": "^7.4.1",
+    "squizlabs/php_codesniffer": "^3.6"
   },
   "autoload": {
     "psr-4": {

phpcs.xml

@@ -0,0 +1,29 @@
+<?xml version="1.0"?>
+<ruleset name="globalis/chargebee-php-sdk">
+  <description>globalis/chargebee-php-sdk coding standards</description>
+
+  <!-- Scan all files in directory -->
+  <file>.</file>
+
+  <!-- Scan only PHP files -->
+  <arg name="extensions" value="php"/>
+
+  <!-- Ignore dependencies -->
+  <exclude-pattern>/vendor/</exclude-pattern>
+
+  <!-- Show colors in console -->
+  <arg value="-colors"/>
+
+  <!-- Show sniff codes in all reports -->
+  <arg value="ns"/>
+
+  <!-- Use PSR-12 as a base -->
+  <rule ref="PSR12"/>
+
+  <!-- Custom rule: disallow long `array()` syntax, use short `[]` syntax instead -->
+  <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
+
+  <rule ref="PSR1.Methods.CamelCapsMethodName">
+    <exclude-pattern>./tests/*</exclude-pattern>
+  </rule>
+</ruleset>

src/Api/AbstractApi.php

@@ -125,7 +125,7 @@ protected function post($path, array $parameters = [], $requestHeaders = [])
      */
     protected function url(string $endpoint, ...$replacements): string
     {
-        return $this->client->baseUrl.vsprintf($endpoint, $replacements);
+        return $this->client->baseUrl . vsprintf($endpoint, $replacements);
     }
 
     /**
@@ -137,7 +137,7 @@ protected function url(string $endpoint, ...$replacements): string
     private function preparePath($path, array $parameters = []): string
     {
         if (count($parameters) > 0) {
-            $path .= '?'.QueryStringBuilder::build($parameters);
+            $path .= '?' . QueryStringBuilder::build($parameters);
         }
 
         return $path;

src/Client.php

@@ -85,7 +85,7 @@ public function __construct(string $site = '', string $key = '', Builder $httpCl
 
     public static function eventDispatcher()
     {
-        if(is_null(self::$eventDispatcher)) {
+        if (is_null(self::$eventDispatcher)) {
             self::$eventDispatcher = new EventDispatcher();
         }
 

src/Events/EventChargebeeApiResponseError.php

@@ -4,5 +4,4 @@
 
 class EventChargebeeApiResponseError extends EventChargebeeApiResponse
 {
-
 }

src/Events/EventChargebeeApiResponseSuccess.php

@@ -4,5 +4,4 @@
 
 class EventChargebeeApiResponseSuccess extends EventChargebeeApiResponse
 {
-
 }

src/HttpClient/Message/QueryStringBuilder.php

@@ -34,13 +34,13 @@ public static function build($query)
     private static function encode($query, $prefix)
     {
         if (!is_array($query)) {
-            return static::rawurlencode($prefix).'='.static::rawurlencode($query);
+            return static::rawurlencode($prefix) . '=' . static::rawurlencode($query);
         }
 
         $isIndexedArray = static::isIndexedArray($query);
 
         return implode('&', array_map(function ($value, $key) use ($prefix, $isIndexedArray) {
-            $prefix = $isIndexedArray ? $prefix.'[]' : $prefix.'['.$key.']';
+            $prefix = $isIndexedArray ? $prefix . '[]' : $prefix . '[' . $key . ']';
 
             return static::encode($value, $prefix);
         }, $query, array_keys($query)));

src/Util/Str.php

@@ -27,7 +27,7 @@ public static function removeQueryArgs($url): string
     {
         $url = parse_url($url);
 
-        if(empty($url)) {
+        if (empty($url)) {
             return $url;
         }
 

tests/Unit/HttpClient/Message/QueryStringBuilderTest.php

@@ -76,12 +76,12 @@ public function queryStringProvider()
                     ],
                 ],
             ],
-            'search=a%20project'.
-            '&owned=true'.
-            '&iids%5B%5D=88&iids%5B%5D=86'.
-            '&assoc%5Ba%5D=b&assoc%5Bc%5D%5Bd%5D=e&assoc%5Bc%5D%5Bf%5D=g'.
-            '&nested%5Ba%5D%5B%5D%5Bb%5D=c&nested%5Ba%5D%5B%5D%5Bd%5D=e'.
-            '&nested%5Ba%5D%5B%5D%5Bf%5D%5Bg%5D=h&nested%5Ba%5D%5B%5D%5Bf%5D%5Bi%5D=j'.
+            'search=a%20project' .
+            '&owned=true' .
+            '&iids%5B%5D=88&iids%5B%5D=86' .
+            '&assoc%5Ba%5D=b&assoc%5Bc%5D%5Bd%5D=e&assoc%5Bc%5D%5Bf%5D=g' .
+            '&nested%5Ba%5D%5B%5D%5Bb%5D=c&nested%5Ba%5D%5B%5D%5Bd%5D=e' .
+            '&nested%5Ba%5D%5B%5D%5Bf%5D%5Bg%5D=h&nested%5Ba%5D%5B%5D%5Bf%5D%5Bi%5D=j' .
             '&nested%5Ba%5D%5B%5D%5Bf%5D%5Bk%5D%5B%5D=87&nested%5Ba%5D%5B%5D%5Bf%5D%5Bk%5D%5B%5D=89',
         ];
     }

tests/Unit/HttpClient/Message/ResponseFormatterTest.php

@@ -14,7 +14,7 @@ public function should_get_content()
         $body = ['foo' => 'bar'];
         $response = new Response(
             200,
-            ['Content-Type'=> 'application/json'],
+            ['Content-Type' => 'application/json'],
             \GuzzleHttp\Psr7\Utils::streamFor(json_encode($body))
         );
 
@@ -48,7 +48,7 @@ public function should_get_content_invalid_json()
         $body = 'foobar';
         $response = new Response(
             200,
-            ['Content-Type'=> 'application/json'],
+            ['Content-Type' => 'application/json'],
             \GuzzleHttp\Psr7\Utils::streamFor($body)
         );