Added support for build tags to generated code #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Hey, just wanted to follow up and see if there's anything else I would need to have this reviewed? |
urandom
approved these changes
Sep 12, 2023
Thanks for the work. |
urandom
approved these changes
Sep 12, 2023
urandom
approved these changes
Sep 12, 2023
|
thanks for approving @urandom! anything else I need to do to get this merged? |
urandom
approved these changes
Oct 8, 2023
|
so @urandom I see you've approved it but I'm still seeing the message that a review is still needed by someone with write access |
|
I'm seeing the same thing. Perhaps it's time for me to clone this repository to gain back access to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that adds a new flag to allow for build tags to be added to generated files. This can be useful when you have different structures gated behind build tags and need different methods generated. (Let me know if you need me to open an issue to go with this or anything like that)