Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-for with several applyPureReactInVue components breaks reactivity #120

Closed
nhaustov opened this issue Apr 14, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@nhaustov
Copy link

Using applyPureReactInVue sometimes causes reactivity to stop working. I have created a simple example based on dev-project-vue3 (full diff attached). Typing into inputs does not cause model to update. Same React components with applyReactInVue wrappers works.

    <PureBox>
      <span>v-for with PureInput wrapped in PureBox breaks. Typing into inputs do not change values.</span>
      <PureBox v-for="e in arr2" :key="e.id">
          <PureInput :value="e.value" @change="e.value = $event.target.value"/>
      </PureBox>
    </PureBox>

...
const PureBox = applyPureReactInVue(ReactBox)
const PureInput = applyPureReactInVue(ReactInput)

diff.txt

@devilwjp
Copy link
Collaborator

devilwjp commented Apr 18, 2024

@nhaustov Thx! This bug will be fixed recently.

devilwjp added a commit that referenced this issue Apr 21, 2024
devilwjp added a commit that referenced this issue Apr 21, 2024
devilwjp added a commit that referenced this issue Apr 21, 2024
devilwjp added a commit that referenced this issue Apr 21, 2024
@devilwjp
Copy link
Collaborator

devilwjp commented Apr 21, 2024

@nhaustov try 2.3.17-beta.1, npm i veaury@beta

devilwjp added a commit that referenced this issue Apr 21, 2024
@nhaustov
Copy link
Author

@devilwjp Confirmed - the fix works with the simple example as well as my more complex app. Thanks - appreciate your work! I do have few more issues to report separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants