Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a newer manylinux2010_x86_64 Docker image with auditwheel 4.0.0. #804

Merged
merged 2 commits into from
Jun 26, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Jun 25, 2021

Description

Attempt to fix #803.

Gets a newer manylinux2010_x86_64 Docker image with auditwheel 4.0.0.

See this comment for details: #803 (comment)

This patch, if correct, will need to be released as freud version 2.6.2.

How Has This Been Tested?

A reviewer should verify that the wheels are patched using auditwheel 4.0.0. That should correct the RPATH issues. I'll tag @klarh and @tommy-waltmann for review since you've both expressed interest in this issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@bdice bdice requested a review from a team as a code owner June 25, 2021 22:40
@bdice bdice requested review from klywang, klarh and tommy-waltmann and removed request for a team and klywang June 25, 2021 22:40
@bdice bdice self-assigned this Jun 25, 2021
@bdice bdice added bug Something isn't working building & installation labels Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #804 (0bc0c28) into master (103573c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   55.68%   55.68%           
=======================================
  Files          16       16           
  Lines        2462     2462           
  Branches       34       34           
=======================================
  Hits         1371     1371           
  Misses       1077     1077           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103573c...0bc0c28. Read the comment docs.

Copy link
Contributor

@klarh klarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wheel built from CI does have a fixed RPATH and it resolves the issue I was having, so it seems good to me. Thanks @bdice !

@bdice bdice merged commit 0c4bc83 into master Jun 26, 2021
@bdice bdice deleted the manylinux-auditwheel-4.0.0 branch June 26, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working building & installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPATH not getting set for linux wheel for release 2.6.1
2 participants