Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump signac and signac-flow #50

Merged
merged 4 commits into from
May 1, 2023
Merged

Bump signac and signac-flow #50

merged 4 commits into from
May 1, 2023

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR bumps both signac and signac-flow, taking the place of #47 and #48 . It also fixes a typo in requirements.txt

Motivation and context

Bumping signac and signac-flow individually will necessary cause errors, due to the major version bump in signac and the new version requirements established between the packages.

How has this been tested?

If CI tests pass, we are good to go.

Checklist:

@tommy-waltmann tommy-waltmann requested review from a team and joaander and removed request for a team April 25, 2023 21:45
signac==1.8.0
signac-flow==0.24.0
signac==2.0.0
signac-flow==0.25.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
signac-flow==0.25.1
signac-flow==0.25.0

0.25.1 doesn't exist yet: https://pypi.org/project/signac-flow/#history

signac >= 1.8.0
signac-flow >= 1.22.0
signac >= 2.0.0
signac-flow >= 0.25.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
signac-flow >= 0.25.1
signac-flow >= 0.25.0

@tommy-waltmann
Copy link
Collaborator Author

It appears that they merged a release branch a few days ago, but the release doesn't seem to have been made yet. The 0.25.0 release of flow had a critical bug where the -f flag couldn't be used on the command line (see here), so we should wait until the 0.25.1 release is made before merging this.

@joaander
Copy link
Member

joaander commented Apr 26, 2023

This bug prevents all use of signac-flow? Or just the -f command line option? hoomd-validation does not rely on the -f option.

Edit: We can wait if a 0.25.1 release is imminent. It will save us a depdendabot pull request on May 1.

@tommy-waltmann
Copy link
Collaborator Author

Looks like 0.25.1 is on PyPI now: https://pypi.org/project/signac-flow/

The conda-forge package should be available later today or tomorrow

@joaander
Copy link
Member

hoomd-validation uses PyPI.

@joaander
Copy link
Member

I reran the build. It does appear that we are using removed APIs that need updating.

    project = signac.init_project(root=config.project_root)
TypeError: init_project() got an unexpected keyword argument 'root'

Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit 6f614e2 into main May 1, 2023
@joaander joaander deleted the fix/bump-signac branch May 1, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants