-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump signac and signac-flow #50
Conversation
signac==1.8.0 | ||
signac-flow==0.24.0 | ||
signac==2.0.0 | ||
signac-flow==0.25.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signac-flow==0.25.1 | |
signac-flow==0.25.0 |
0.25.1 doesn't exist yet: https://pypi.org/project/signac-flow/#history
signac >= 1.8.0 | ||
signac-flow >= 1.22.0 | ||
signac >= 2.0.0 | ||
signac-flow >= 0.25.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signac-flow >= 0.25.1 | |
signac-flow >= 0.25.0 |
It appears that they merged a release branch a few days ago, but the release doesn't seem to have been made yet. The 0.25.0 release of flow had a critical bug where the -f flag couldn't be used on the command line (see here), so we should wait until the 0.25.1 release is made before merging this. |
This bug prevents all use of Edit: We can wait if a 0.25.1 release is imminent. It will save us a depdendabot pull request on May 1. |
Looks like 0.25.1 is on PyPI now: https://pypi.org/project/signac-flow/ The conda-forge package should be available later today or tomorrow |
|
I reran the build. It does appear that we are using removed APIs that need updating.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This PR bumps both
signac
andsignac-flow
, taking the place of #47 and #48 . It also fixes a typo inrequirements.txt
Motivation and context
Bumping
signac
andsignac-flow
individually will necessary cause errors, due to the major version bump insignac
and the new version requirements established between the packages.How has this been tested?
If CI tests pass, we are good to go.
Checklist:
CONTRIBUTORS.md
) in the pull request source branch.