-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation of query namespaces. #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks clear to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is using doc_filter
arguments then officially deprecated?
@csadorf I think |
@bdice This is such core API that I think it would present a strong burden for migration. So, if we did this then I would suggest we explore providing some tooling (for example using Bowler) to automatically migrate existing projects. Basically rewrite |
I'm inclined to punt on removing/providing migration tools until a 3.0 release since I do think that it will be a significant migration burden for old scripts. My preference would simply be to preferentially document the new API going forward so that new scripts do not use this, making it more likely that by the time of a 3.0 release the migration would be a much lighter burden since scripts using |
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Description
Add documentation for query filters that combine state point and document keys.
Motivation and Context
Accompanies glotzerlab/signac#332
Checklist: