Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization: don't deepcopy directives #421

Merged
merged 5 commits into from
Jan 8, 2021
Merged

Optimization: don't deepcopy directives #421

merged 5 commits into from
Jan 8, 2021

Commits on Jan 8, 2021

  1. Modify _JobOperation construction to not deepcopy directives 

    Deepcopying directives is expensive since it is not a pure data
structure. This commit just converts the directives to a pure data
structure (i.e. a ``dict``). In addition, we pass the user specified
directives (as opposed to the environment specified directives) to
``_JobOperation``. This should improve the performance of run and
submit.
    @b-butler
    b-butler committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    3e0ec67 View commit details
    Browse the repository at this point in the history

  2. Only evaluate directives when unevaluated. 

    Adds a check to prevent the same directive from being evaluated twice.
This should speed up the evaluation of multi-operation groups.
    @b-butler
    b-butler committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    6fe0748 View commit details
    Browse the repository at this point in the history

  3. Add back (fixed) comment about user directives.

    @bdice
    bdice committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    c034818 View commit details
    Browse the repository at this point in the history

  4. Update docstring.

    @bdice
    bdice authored Jan 8, 2021
    Configuration menu
    Copy the full SHA
    cd620df View commit details
    Browse the repository at this point in the history

  5. Use dict constructor instead of dict comprehension.

    @bdice
    bdice authored Jan 8, 2021
    Configuration menu
    Copy the full SHA
    482f774 View commit details
    Browse the repository at this point in the history